Migrate to pydantic>=2.5, torch==2.1.1, ray[default]>=2.9
#534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spillai
added
optimizations
spillai
force-pushed
the
spillai/0.2.0-dev
branch
2 times, most recently
from
9811603
to
df9c886
Compare
- various migration upgrades to ModelSpec and other dataclasses with new pydantic `field_validator` syntax
spillai
force-pushed
the
spillai/0.2.0-dev
branch
from
df9c886
to
32a988e
Compare
outtanames
approved these changes
Jan 29, 2024
| @@ -151,22 +149,42 @@ class FunctionSignature: | |||
| method: str | |||
| """Class method name. (e.g. forward, __call__ etc)""" | |||
|
|
|||
| init_args: Tuple[Any, ...] = field(default_factory=tuple) | |||
There was a problem hiding this comment.
[nit] might be good to validate method != None? same for func_or_cls
There was a problem hiding this comment.
That is already handled in the new pydantic validation
| @@ -237,7 +237,7 @@ def _get_actor_options(cls, spec: ModelSpec, deployment: ModelDeploymentSpec) -> | |||
|
|
|||
| if spec.runtime_env is not None: | |||
| logger.debug("Using custom runtime environment, this may take a while to build.") | |||
| actor_opts["runtime_env"] = RuntimeEnv(**asdict(spec.runtime_env)) | |||
| actor_opts["runtime_env"] = RuntimeEnv(**spec.runtime_env.model_dump()) | |||
| @@ -238,7 +238,7 @@ def txt2img(self, texts: str) -> Image.Image: | |||
|
|
|||
| # Image generation (txt2img) | |||
| txt2img_signature = FunctionSignature( | |||
| Custom, | |||
| func_or_cls=Custom, | |||
There was a problem hiding this comment.
'func_or_class' is kind of a confusing name given that we also have method.
This was referenced Feb 1, 2024
spillai
added a commit
to autonomi-ai/nos-playground
that referenced
this pull request
Feb 8, 2024
Depends on `0.2.0` release autonomi-ai/nos#534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pydantic>2.5upgrade2.9for pydantic>2 update: [ray serve] incompatibility with pydantic >=2.0 ray-project/ray#39722agi-packwithpydantic>2support: Migrate topydantic>=2.5spillai/agi-pack#16field_validatorsyntaxRelated issues
#220
Checks
make lint: I've runmake lintto lint the changes in this PR.make test: I've made sure the tests (make test-cpuormake test) are passing.