-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Analyze.best_params as dictionary #502
Labels
priority: MEDIUM
medium priority
topic: experience
Having to do with researcher/developer experience.
value: ⭐
low value
Comments
Welcome to Talos community! Thanks so much for creating your first issue :) |
mikkokotila
added
value: ⭐
low value
topic: experience
Having to do with researcher/developer experience.
labels
Nov 9, 2020
mikkokotila
changed the title
Reporting.best_params returns the attributes list as well
Return Analyze.best_params as dictionary
Nov 15, 2020
I think best make it into a dictionary. The goal here is to be able to feed back to the experiment programmatically. |
I second this. I have no idea how to read my best_params output. Documentation also needs to be added for the parameters of best_params(). exclude is required, but I don't know what it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: MEDIUM
medium priority
topic: experience
Having to do with researcher/developer experience.
value: ⭐
low value
Currently
Reporting.best_params
will return an array containing the best parameter values. However, it will not return the corresponding parameter names and this makes it difficult to tell apart which value stands for which parameter.1) I think Talos should add
In commands/analyze.py, I think it would be better if
best_params
returned the complete dataframe (out
) instead of the values (out.values
)2) Once implemented, I can see how this feature will
It will be easier to understand which values correspond to which parameters
3) I believe this feature is
nice to have
4) Given the chance, I'd be happy to make a PR for this feature
definitely
The text was updated successfully, but these errors were encountered: