Rename types to use proper PascalCase #79
Conversation
richardpringle
requested review from
exdx,
xinifinity,
gyuho,
hexfusion,
rkuris,
patrick-ogrady and
StephenButtolph
as code owners
| pub fn new(mut receiver: Receiver<Request>, owned_path: PathBuf, cfg: DBConfig) -> Self { | ||
| let db = DB::new(owned_path, &cfg).unwrap(); | ||
| pub fn new(mut receiver: Receiver<Request>, owned_path: PathBuf, cfg: DbConfig) -> Self { | ||
| let db = Db::new(owned_path, &cfg).unwrap(); |
There was a problem hiding this comment.
Hmm, not sure if DB has to be pascalcase as it is pretty common to use as DB.
There was a problem hiding this comment.
They use Uuid vs UUID as an example. You essentially should never have two uppercase letters in a row for a type name
fwdctl/src/create.rs
Outdated
| @@ -77,7 +77,7 @@ pub struct Options { | |||
| long, | |||
| required = false, | |||
| default_value_t = 10, | |||
| value_name = "PAYLOAD_MAX_WALK", | |||
| value_name = "PAYLOAD_MAX_WalK", | |||
There was a problem hiding this comment.
Should this follow SCREAMING_SNAKE_CASE or PascalCase style?
There was a problem hiding this comment.
Good catch, whoops!
richardpringle
force-pushed
the
PascalCase
branch
3 times, most recently
from
e8549b9
to
2644149
Compare
fwdctl/src/create.rs
Outdated
| @@ -172,61 +172,61 @@ pub struct Options { | |||
| long, | |||
| required = false, | |||
| default_value_t = 256, | |||
| value_name = "DISK_BUFFER_WAL_MAX_AIO_REQUESTS", | |||
| help = "Maximum number of concurrent async I/O requests in WAL." | |||
| value_name = "DISK_BUFFER_Wal_MAX_AIO_REQUESTS", | |||
There was a problem hiding this comment.
keep it as SCREAMING_SNAKE_CASE for all other places in this file?
This adheres to Proper Rust naming conventions
richardpringle
force-pushed
the
PascalCase
branch
from
2f951d6
to
129378c
Compare
The diff is super easy to check with the But if you ever want to see the actual diff between commits, you just have to use the compare functionality: It's actually better than going through one commit at a time since I may have changed something in one commit then changed it back in another which would actually make it harder to review. |
No worries, I understand sometimes that can happen, happened to me as well :). it's just force push during review seems not a good practice todogroup/gh-issues#53, avoid using it if possible. |
This adheres to Proper Rust naming conventions