Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flip a bitmap by range #77

Merged
merged 3 commits into from
Nov 5, 2020
Merged

flip a bitmap by range #77

merged 3 commits into from
Nov 5, 2020

Conversation

jiangtao244
Copy link
Contributor

aviggiano
aviggiano reviewed Nov 4, 2020
View reviewed changes
Copy link
Owner

@aviggiano aviggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems perfect!

Could you just add a test on the tests/integrations_1.sh file ?

I believe you could do the exact same test as in issue #73

@jiangtao244
Copy link
Contributor Author

Test added.

Valgrid find some memory leak, is this matter?

@aviggiano
Copy link
Owner

I believe this was already there (related to #2)

I'll merge this PR and create a separate issue to investigate the memory leaks.

@aviggiano aviggiano merged commit da4a025 into aviggiano:master Nov 5, 2020
@jiangtao244
Copy link
Contributor Author

@aviggiano ,
Sorry, I missed a test case when lastOffset < Max

Example:

R.SETINTARRAY src 1 3 5
R.BITOP NOT dst src 3
R.GETINTARRAY dst

Get: 0 2 5
Expect: 0 2

Need to cut the bits out of range.

@aviggiano aviggiano mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviggiano aviggiano aviggiano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiangtao244 @aviggiano