chore: cleanup exception messaging #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
reviewed
Oct 31, 2023
| @@ -41,13 +41,13 @@ | |||
| import javax.inject.Inject; | |||
|
|
|||
| public interface IotAuthClient { | |||
| Optional<String> getActiveCertificateId(String certificatePem); | |||
| Optional<String> getActiveCertificateId(String certificatePem) throws CloudServiceInteractionException; | |||
There was a problem hiding this comment.
this breaks out interface doesn't it? Isn't moquette using these methods? If it is, then this is going to break consumers.
There was a problem hiding this comment.
consumers just interact with ClientDevicesAuthServiceApi and AuthenticationExceptions from what i can see, so that should be fine?
robcmann
approved these changes
Oct 31, 2023
MikeDombo
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
CreateIoTThingSessionto disambiguate failures.CloudServiceInteractionExceptiona checked exceptionWhy is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.