Update PR and Main Build for patched dependencies jobs #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adding maven cache in pr buid for faster build
PaurushGarg
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/v1.32.x #669 +/- ##
==================================================
Coverage ? 50.73%
Complexity ? 264
==================================================
Files ? 39
Lines ? 1301
Branches ? 141
==================================================
Hits ? 660
Misses ? 609
Partials ? 32 ☔ View full report in Codecov by Sentry. |
.github/workflows/main-build.yml
Outdated
| @@ -25,7 +25,7 @@ jobs: | |||
| testpatch: | |||
| name: Test patches applied to dependencies | |||
| runs-on: aws-otel-java-instrumentation_ubuntu-latest_32-core | |||
| if: ${{ startsWith(github.ref_name, 'release/v') }} | |||
| if: ${{ hashFiles('.github/patches/**/opentelemetry-java-*.patch') != ''}} | |||
There was a problem hiding this comment.
Suggested change
| if: ${{ hashFiles('.github/patches/**/opentelemetry-java-*.patch') != ''}} | |
| if: ${{ hashFiles('.github/patches/**/opentelemetry-java-*.patch') != ''}} |
I don't think we need this conditional anymore. Running the patch action is a NOOP if no patch files exist.
|
closing pr as another relevant pr has been merged: #670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Creating PR to this release
v1.32.xbranch post v1.32.0 release but before merging tomain, as merging tomainhas CI failure here.prbuildto make subsequent pr builds faster.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.