New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing .format connection string #92

Open

paulofbmarcon opened this issue Oct 15, 2020 · 1 comment

paulofbmarcon commented Oct 15, 2020

hi,
it looks like that in this file https://github.com/aws-samples/amazon-forecast-samples/blob/master/ml_ops/visualization_blog/lambdas/updateresources/update.py
at line 65 it is missing the ".format" with the bucket information.
Shouldn't it be " s3_staging_dir='s3://{}/stage'.format(bucket) " ?

Contributor

shimomut commented Nov 3, 2020

Thank you for your report, and sorry for my response took time.
I am checking the issue now, and will update here.

pedrosola pushed a commit to pedrosola/amazon-forecast-samples that referenced this issue


          Fix issue aws-samples#92

72817dd

pedrosola pushed a commit to pedrosola/amazon-forecast-samples that referenced this issue


          Fix issue aws-samples#92

3f84d91

shimomut added a commit that referenced this issue


          Merge pull request #95 from pedrosola/master

233df46

Fix issue #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment