Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-crawler-wait #1011

Merged
merged 3 commits into from
Nov 12, 2024
Merged

add-crawler-wait #1011

merged 3 commits into from
Nov 12, 2024

Conversation

iakov-aws
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@esc1144 esc1144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not clear on what this means (Timeout exceeded. Crawler '{CRAWLER}' did not complete. But we do not fail the execution). What does it mean to not fail the execution? Should we say "This is not a fatal error and the rest of the deployment operation was successful" or something like that?

cfn-templates/cid-cfn.yml Outdated Show resolved Hide resolved
cfn-templates/cid-cfn.yml Outdated Show resolved Hide resolved
@iakov-aws iakov-aws requested a review from esc1144 November 12, 2024 20:41
@iakov-aws iakov-aws merged commit bd7a32e into main Nov 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants