Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add product storage fields and better messages if CUR does not contain fields #680

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Add product storage fields and better messages if CUR does not contain fields #680

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
535466b
add product_storage
iakov-aws Nov 11, 2023
07e2c9b
add product_storage and better error messages if cur not found
iakov-aws Nov 11, 2023
a3c34e7
add dependency on resource_id
iakov-aws Nov 13, 2023
11282e0
merge and add resource id
iakov-aws Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cid/helpers/cur.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ class CUR(CidBase):
'line_item_line_item_type',
'line_item_operation',
'line_item_product_code',
'line_item_resource_id',
#'line_item_resource_id',
iakov-aws marked this conversation as resolved.
Show resolved Hide resolved
'line_item_unblended_cost',
'line_item_usage_account_id',
Expand Down Expand Up @@ -74,7 +75,7 @@ class CUR(CidBase):
_hasReservations = None
_configured = None
_status = str()


def __init__(self, session) -> None:
super().__init__(session)
Expand All @@ -97,7 +98,7 @@ def athena(self, client) -> Athena:

@property
def configured(self) -> bool:
""" Check if AWS Datacalog and Athena database exist """
""" Check if AWS Data Catalog and Athena database exist """
if self._configured is None:
if self.athena.CatalogName and self.athena.DatabaseName:
self._configured = True
Expand Down