Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cur table issue #999

Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix cur table issue #999

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d173aa
fix cur table issue
iakov-aws Nov 6, 2024
0bbabdb
fix cur table issue
iakov-aws Nov 6, 2024
90ad2eb
fix cur table issue
iakov-aws Nov 6, 2024
cc9d760
refactoring parameters for lambda
iakov-aws Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cfn-templates/cid-cfn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,12 +1939,15 @@ Outputs:
Description: Technical Value - GlueCatalog
Value: !Ref GlueDataCatalog
Export: { Name: !Sub 'cid${Suffix}-GlueCatalog'}
CurDatabaseName:
Description: Technical Value - CurDatabaseName
Value: !If [ UseCUR2, !ImportValue cid-DataExports-Database, !If [NeedDatabase, !Ref CidDatabase, !Ref DatabaseName ] ]
Export: { Name: !Sub 'cid${Suffix}-CurTableName'}
CurTableName:
Description: Technical Value - CurTableName
Value: !If [ NeedCURTable, !Ref MyCURTable, !Ref CURTableName ]
Value: !If [ UseCUR2, 'cur2', !If [ NeedCURTable, !Ref MyCURTable, !Ref CURTableName ] ]
Export: { Name: !Sub 'cid${Suffix}-CurTableName'}
QuickSightUser:
Description: Technical Value - QuickSightUser
Value: !Ref QuickSightUser
Export: { Name: !Sub 'cid${Suffix}-QuickSightUser'}

Export: { Name: !Sub 'cid${Suffix}-QuickSightUser'}
1 change: 1 addition & 0 deletions cfn-templates/cid-plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Resources:
athena-database: {Fn::ImportValue: "cid-AthenaDatabase"}
glue-data-catalog: {Fn::ImportValue: "cid-GlueCatalog"}
cur-table-name: {Fn::ImportValue: "cid-CurTableName"}
cur-database-name: {Fn::ImportValue: "cid-CurDatabaseName"}
quicksight-user: {Fn::ImportValue: "cid-QuickSightUser"}
share-with-account: 'yes'
resources: !If [ResourcesUrlIsEmpty, !Ref 'AWS::NoValue', !Ref ResourcesUrl]
Expand Down
Loading