Skip to content

Commit

Permalink
chore(route53): support new partitions in route53 cross-account deleg…
Browse files Browse the repository at this point in the history
…ator (#29537)

### Issue # (if applicable)

n/a

### Reason for this change

Support new partitions from the AWS JS SDK: https://github.com/aws/aws-sdk-js-v3/blob/05c32e74595113347211ba0584197b665ebab1db/packages/util-endpoints/src/lib/aws/partitions.json#L190-L2

### Description of changes

Support new partitions from the AWS JS SDK: https://github.com/aws/aws-sdk-js-v3/blob/05c32e74595113347211ba0584197b665ebab1db/packages/util-endpoints/src/lib/aws/partitions.json#L190-L214

### Description of how you validated changes

This is a minor update to a mapping that has no existing unit tests. I'm happy to add if desired, but likely unnecessary.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
naiello authored Mar 22, 2024
1 parent 9b79f94 commit 3a78125
Show file tree
Hide file tree
Showing 15 changed files with 25 additions and 23 deletions.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"Properties": {
"Code": {
"S3Bucket": "cdk-hnb659fds-assets-234567890123-af-south-1",
"S3Key": "5e6e9858d1b0f5ba042ceacb850822cb985861c7bd174ceb7659a10daebe43e9.zip"
"S3Key": "aca4a134bf7ace6088b21213be7ab4357e3705f714362b690d76376b8f1df53a.zip"
},
"Timeout": 900,
"MemorySize": 128,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"Properties": {
"Code": {
"S3Bucket": "cdk-hnb659fds-assets-234567890123-us-east-1",
"S3Key": "5e6e9858d1b0f5ba042ceacb850822cb985861c7bd174ceb7659a10daebe43e9.zip"
"S3Key": "aca4a134bf7ace6088b21213be7ab4357e3705f714362b690d76376b8f1df53a.zip"
},
"Timeout": 900,
"MemorySize": 128,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
"Properties": {
"Code": {
"S3Bucket": "cdk-hnb659fds-assets-234567890123-us-east-1",
"S3Key": "5e6e9858d1b0f5ba042ceacb850822cb985861c7bd174ceb7659a10daebe43e9.zip"
"S3Key": "aca4a134bf7ace6088b21213be7ab4357e3705f714362b690d76376b8f1df53a.zip"
},
"Timeout": 900,
"MemorySize": 128,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ function route53Region(region: string) {
'us-gov': 'us-gov-west-1',
'us-iso': 'us-iso-east-1',
'us-isob': 'us-isob-east-1',
'eu-isoe': 'eu-isoe-west-1',
'us-isof': 'us-isof-south-1',
};

for (const [prefix, mainRegion] of Object.entries(partitions)) {
Expand Down

0 comments on commit 3a78125

Please sign in to comment.