fix(s3): lifecycle rule dates require trailing Z

aws · Nov 27, 2023 · d48158f · d48158f
1 parent 1a2481e
commit d48158f
Show file tree

Hide file tree

Showing 10 changed files with 30 additions and 28 deletions.
diff --git a/...sting/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/aws-cdk-s3.assets.json b/...sting/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/aws-cdk-s3.assets.json
diff --git a/...ing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/aws-cdk-s3.template.json b/...ing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/aws-cdk-s3.template.json
@@ -6,11 +6,11 @@
     "LifecycleConfiguration": {
      "Rules": [
       {
-       "ExpirationDate": "2019-10-01T00:00:00",
+       "ExpirationDate": "2019-10-01T00:00:00Z",
        "Status": "Enabled"
       },
       {
-       "ExpirationDate": "2019-10-01T00:00:00",
+       "ExpirationDate": "2019-10-01T00:00:00Z",
        "ObjectSizeGreaterThan": 500,
        "ObjectSizeLessThan": 600,
        "Status": "Enabled"

diff --git a/...ges/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/cdk.out b/...ges/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/cdk.out
diff --git a/.../integ.lifecycle.js.snapshot/cdkinteglifecycleDefaultTestDeployAssert83FA03B1.assets.json b/.../integ.lifecycle.js.snapshot/cdkinteglifecycleDefaultTestDeployAssert83FA03B1.assets.json
diff --git a/.../@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/integ.json b/.../@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/integ.json
diff --git a/...ws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/manifest.json b/...ws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/manifest.json
diff --git a/...s/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/tree.json b/...s/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.js.snapshot/tree.json
diff --git a/packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.ts b/packages/@aws-cdk-testing/framework-integ/test/aws-s3/test/integ.lifecycle.ts
@@ -23,4 +23,4 @@ new Bucket(stack, 'MyBucket', {
 
 new IntegTest(app, 'cdk-integ-lifecycle', {
   testCases: [stack],
-});
+});
diff --git a/packages/@aws-cdk/cli-lib-alpha/THIRD_PARTY_LICENSES b/packages/@aws-cdk/cli-lib-alpha/THIRD_PARTY_LICENSES
@@ -207,7 +207,7 @@ The @aws-cdk/cli-lib-alpha package includes the following third-party software/l
 
 ----------------
 
-** @jsii/check-node@1.91.0 - https://www.npmjs.com/package/@jsii/check-node/v/1.91.0 | Apache-2.0
+** @jsii/check-node@1.92.0 - https://www.npmjs.com/package/@jsii/check-node/v/1.92.0 | Apache-2.0
 jsii
 Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 
@@ -471,7 +471,7 @@ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH RE
 
 ----------------
 
-** aws-sdk@2.1492.0 - https://www.npmjs.com/package/aws-sdk/v/2.1492.0 | Apache-2.0
+** aws-sdk@2.1498.0 - https://www.npmjs.com/package/aws-sdk/v/2.1498.0 | Apache-2.0
 AWS SDK for JavaScript
 Copyright 2012-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.
 
@@ -668,7 +668,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
 ----------------
 
-** cdk-from-cfn@0.67.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.67.0 | MIT OR Apache-2.0
+** cdk-from-cfn@0.69.0 - https://www.npmjs.com/package/cdk-from-cfn/v/0.69.0 | MIT OR Apache-2.0
 
 ----------------
 

diff --git a/packages/aws-cdk-lib/core/lib/runtime.ts b/packages/aws-cdk-lib/core/lib/runtime.ts
@@ -32,7 +32,7 @@ export function dateToCloudFormation(x?: Date): any {
   }
 
   // eslint-disable-next-line max-len
-  return `${x.getUTCFullYear()}-${pad(x.getUTCMonth() + 1)}-${pad(x.getUTCDate())}T${pad(x.getUTCHours())}:${pad(x.getUTCMinutes())}:${pad(x.getUTCSeconds())}`;
+  return `${x.getUTCFullYear()}-${pad(x.getUTCMonth() + 1)}-${pad(x.getUTCDate())}T${pad(x.getUTCHours())}:${pad(x.getUTCMinutes())}:${pad(x.getUTCSeconds())}Z`;
 }
 
 /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,4 +23,4 @@ new Bucket(stack, 'MyBucket', { @@
     new IntegTest(app, 'cdk-integ-lifecycle', {
       testCases: [stack],
-    });
+    });