-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(service-catalog): allow Product Stack to override analytics repo…
…rting and stack descriptions (#31985) ### Issue # (if applicable) Closes #31924 ### Reason for this change Product Stack cannot override analytics reporting and descriptions. Support these two props. ### Description of changes The reason I didn't choose to allow ProductStackProps to extend StackProps and instead manually add these two properties are because all of the other properties, i.e. `stackName`, `env`, `notificationArns`, `terminationProtection`, `crossRegionReferences`, `permissionsBoundary`, `suppressTemplateIndentation`, do not mutate the stack template but are used by CDK CLI. These properties have no impact on the Product Stack template generated and thus I did not include them. ### Description of how you validated changes Unit and integ tests added. ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
11 changed files
with
66 additions
and
26 deletions.
There are no files selected for viewing
8 changes: 4 additions & 4 deletions
8
...ws-servicecatalog/test/integ.product.js.snapshot/integ-servicecatalog-product.assets.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...duct.js.snapshot/integservicecatalogproductSNSTopicProduct1B8D03934.product.template.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{ | ||
"Description": "foo bar", | ||
"Resources": { | ||
"TopicProductD757E287": { | ||
"Type": "AWS::SNS::Topic" | ||
|
1 change: 1 addition & 0 deletions
1
...duct.js.snapshot/integservicecatalogproductSNSTopicProduct24C7C16DA.product.template.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{ | ||
"Description": "foo bar", | ||
"Resources": { | ||
"TopicProductD757E287": { | ||
"Type": "AWS::SNS::Topic" | ||
|
1 change: 1 addition & 0 deletions
1
...duct.js.snapshot/integservicecatalogproductSNSTopicProduct3B51CF591.product.template.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{ | ||
"Description": "foo bar", | ||
"Resources": { | ||
"TopicProductD757E287": { | ||
"Type": "AWS::SNS::Topic" | ||
|
7 changes: 2 additions & 5 deletions
7
...ting/framework-integ/test/aws-servicecatalog/test/integ.product.js.snapshot/manifest.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
26 changes: 13 additions & 13 deletions
26
...-testing/framework-integ/test/aws-servicecatalog/test/integ.product.js.snapshot/tree.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...story4D520FF1.integservicecatalogproductSNSTopicProduct3B51CF591.v1.product.template.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{ | ||
"Description": "foo bar", | ||
"Resources": { | ||
"TopicProductD757E287": { | ||
"Type": "AWS::SNS::Topic" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters