Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(nested-stack): impossible to manually set Nested Stack Name #19371

Closed
2 tasks
amir-faliam opened this issue Mar 12, 2022 · 3 comments
Closed
2 tasks

(nested-stack): impossible to manually set Nested Stack Name #19371

amir-faliam opened this issue Mar 12, 2022 · 3 comments
Assignees
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@amir-faliam
Copy link

Description

I want to be able to manually set the name of a NestedStack but currently there is no way to do so.

Use Case

I'm migrating my infrastructure from Amplify over to CDK and my strategy for refactoring the management of the resources is to maintain the stack/resource names when I recreate them in CDK.

All of the other resources (i.e. root stack, Cognito, Dynamodb, etc) haven't been an issue, but nested stack seems to be the only thing we can't manually set the name on.

It seems weird that we can define stack names for root stack but not for nested stacks.

Proposed Solution

introduce stack name as a parameter for NestedStackProps similar to how it's done for normal Cloudformation Stacks

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@amir-faliam amir-faliam added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 12, 2022
@github-actions github-actions bot added the @aws-cdk/aws-cloudformation Related to AWS CloudFormation label Mar 12, 2022
@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 31, 2022
@rix0rrr
Copy link
Contributor

rix0rrr commented Apr 7, 2022

@rix0rrr rix0rrr closed this as completed Apr 7, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@flyingImer
Copy link
Contributor

flyingImer commented Apr 8, 2022

@rix0rrr
the nested stack name is auto generated from its logical id by CFN, currently the logical id is authored by CDK in the format of <nested-stack-id>NestedStack<nested-stack-id>NestedStackResources, which is not that readable, I feel (similar request: #19099)

it would be great to let CDK user to provide the logical id, which may be close to the request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

4 participants