Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ecs): AsgCapacityProvider and AsgCapacityProviderProps should expose InstanceWarmupPeriod #28190

Closed
2 tasks
jeffb4 opened this issue Nov 29, 2023 · 3 comments · Fixed by #28194
Closed
2 tasks

(aws-ecs): AsgCapacityProvider and AsgCapacityProviderProps should expose InstanceWarmupPeriod #28190

jeffb4 opened this issue Nov 29, 2023 · 3 comments · Fixed by #28194
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@jeffb4
Copy link
Contributor

jeffb4 commented Nov 29, 2023

Describe the feature

aws-ecs.AsgCapacityProviderProps should expose the InstanceWarmupPeriod property from the L1 provider

Use Case

Allowing this configuration of the underlying CfnCapacityProvider L1 object would allow CDK users defining ECS clusters to effectively lower or raise the expected time for instances to become available, without delving into the L1 object themselves.

Proposed Solution

No response

Other Information

In the alternate, a user can specify their own L1 CfnCapacityProvider instead of using AsgCapacityProvider

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

v2.99.1

Environment details (OS name and version, etc.)

MacOS 14.1.1
@jeffb4 jeffb4 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Nov 29, 2023
@khushail
Copy link
Contributor

thanks @jeffb4 for submitting this. Contributions are welcome from the community.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2023
@msambol
Copy link
Contributor

msambol commented Nov 29, 2023

I'll take this.

@msambol msambol mentioned this issue Nov 29, 2023
Merged
@mergify mergify bot closed this as completed in #28194 Nov 30, 2023
mergify bot pushed a commit that referenced this issue Nov 30, 2023
@msambol
feat(ecs): add instance warmup period prop (#28194)
990fab3 
Closes #28190.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Dec 1, 2023
Closed
chenjane-dev pushed a commit to chenjane-dev/aws-cdk that referenced this issue Dec 5, 2023
@msambol @chenjane-dev
feat(ecs): add instance warmup period prop (aws#28194)
f3a7744 
Closes aws#28190.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): add instance warmup period prop msambol/aws-cdk
3 participants
@jeffb4 @msambol @khushail