Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CLI): Deploy Stacks by Glob doesn't work with Stages #28297

Open
haljarrett opened this issue Dec 8, 2023 · 2 comments
Open

(CLI): Deploy Stacks by Glob doesn't work with Stages #28297

haljarrett opened this issue Dec 8, 2023 · 2 comments
Labels
bug This issue is a bug. cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort p2 package/tools Related to AWS CDK Tools or CLI

Comments

@haljarrett
Copy link

Describe the bug

When deploying from the CLI, I'd expect that cdk deploy "beta*" would deploy beta/stackA, beta/stackB, and beta/X/stackC. However, it seems the glob will not pass the / marker. cdk deploy "beta/*" works as expected.

Expected Behavior

I would expect that any stacks matched by the glob would be deployed - this would be the happy path for deploying a whole Stage.

Current Behavior

$ cdk deploy "beta*"

No stacks match the name(s) beta*

Given:

$ cdk list

toplevelA
toplevelB
beta/nested

Reproduction Steps

POC for a related issue: https://github.com/haljarrett/cdk-stage-issue

Execute cdk deploy "beta*" and find that no stacks are matched.

Possible Solution

Suspect that this is a related issue to the one I opened yesterday: #28283, and maybe has to do with how stack names are matched in cdk-toolkit.ts.

Additional Information/Context

No response

CDK CLI Version

2.114.1 (build 02bbb1d)

Framework Version

No response

Node.js Version

v20.6.0

OS

MacOS

Language

TypeScript

Language Version

No response

Other information

No response

@haljarrett haljarrett added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 8, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Dec 8, 2023
@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 12, 2023
@pahud
Copy link
Contributor

pahud commented Dec 12, 2023

According to #14379, are you able to match it with cdk deploy "beta**"?

@pahud pahud added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 12, 2023
@haljarrett
Copy link
Author

cdk deploy "**", cdk deploy "beta/*", and cdk deploy "beta/**" work as described in that PR, but I get the following failure:

$ cdk deploy "beta**"

No stacks match the name(s) beta**

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 13, 2023
@pahud pahud added the cli Issues related to the CDK CLI label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

2 participants