Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudfront: Missing origin event types in FunctionEventType #29354

Closed
1 of 2 tasks
emilrowland opened this issue Mar 4, 2024 · 2 comments
Closed
1 of 2 tasks

cloudfront: Missing origin event types in FunctionEventType #29354

emilrowland opened this issue Mar 4, 2024 · 2 comments
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront feature-request A feature should be added or improved.

Comments

@emilrowland
Copy link
Contributor

Describe the feature

Missing origin event types in FunctionEventType.
According to: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-functionassociation.html#aws-properties-cloudfront-distribution-functionassociation-properties
The following are valid event types for CloudFront functions:
viewer-request | viewer-response | origin-request | origin-response

Currently only viewer-request | viewer-response exists in CDK.

Use Case

Need it to be able to declare CloudFront functions on the origin request

Proposed Solution

Extend FunctionEventType with all available types: viewer-request | viewer-response | origin-request | origin-response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.128.0

Environment details (OS name and version, etc.)

Ubuntu 20.04.6 LTS

@emilrowland emilrowland added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 4, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Mar 4, 2024
@emilrowland
Copy link
Contributor Author

Aparently Origin requests are not supported by cloudfront functions only lambda edge supports it.

@emilrowland emilrowland closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@khushail khushail removed the needs-triage This issue or PR still needs to be triaged. label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants