-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDK CLI: region must be in config
file (ignored in credentials
file) since 2.167.0
#32130
Comments
If the statement is in the Strangely enough the AWS CLI does also seem to support the value in both config files, even though it has been specced to only work in the
Examples say the region should go into
|
Interesting findings. What is also somehow strange we have a lot of node scripts with aws sdkv3 running in the same setup (region in /credentials) and they still work fine. |
That is quite weird indeed. It might be that there's a difference between the code paths that determine a region for the purposes of making an API call, versus the code paths that we use to query the region. |
Ah yeah, it's us:
|
config
file (ignored in credentials
file) since 2.167.0
Just for confirmation: after putting the region into |
Labeling the issue as |
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
Comments on closed issues and PRs are hard for our team to see. |
We just didn't consider the shared credentials file as returned by the SDK when loading configuration. Closes #32130. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
From this thread: #32120
By @otbe:
For us the issue is in the region, e.g.
deploy -vvv
Not quite sure how it worked in older aws-cdk versions but the region is specified in
.aws/credentials
similar to thisThat means our stacks are deployed in the wrong region with 2.167.0 🫠
Reverting back to 2.166.0 solves the issue.
Regression Issue
Last Known Working CDK Version
No response
Expected Behavior
Uses my configured region in the INI file
Current Behavior
Uses
us-east-1
Reproduction Steps
See description
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.167.0
Framework Version
No response
Node.js Version
OS
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: