Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-cdk/aws-glue-alpha: pythonShell should not require glueVersion #32148

Closed
1 task
urkle opened this issue Nov 15, 2024 · 3 comments
Closed
1 task

@aws-cdk/aws-glue-alpha: pythonShell should not require glueVersion #32148

urkle opened this issue Nov 15, 2024 · 3 comments
Assignees
Labels
@aws-cdk/aws-glue Related to AWS Glue bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@urkle
Copy link

urkle commented Nov 15, 2024

Describe the bug

When creating a pythongshell job type the GlueVersion should not be required (as it is not used for this mode).

All examples of creating python shell jobs do not specify the GlueVersion at all, just the python version

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

I should be able to omit the glueVersion parameter to JobExecution.pythonShell.

Current Behavior

It throws an error stating that the glue_version parameter is required.

Reproduction Steps

glue.Job(
self, 'ShellJob',
job_name='myShellJob',
role=glue_role,
default_arguments={
"--additional-python-modules": "awswrangler,fastparquet,google-api-python-client,google-auth-oauthlib,google-auth-httplib2",
},
timeout=Duration.minutes(30),
max_concurrent_runs=1,
executable=glue.JobExecutable.python_shell(
python_version=glue.PythonVersion.THREE_NINE,
script=glue.Code.from_asset(glue_script_path('my-shell-job.py')),
)
)

Possible Solution

make it optional for PythonShellExecutableProps

Additional Information/Context

No response

CDK CLI Version

2.166.0

Framework Version

No response

Node.js Version

18.16.1

OS

macOS 12.7.6

Language

Python

Language Version

3.9

Other information

@aws-cdk/aws-glue-alpha = 2.166.0a0

@urkle urkle added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 15, 2024
@github-actions github-actions bot added the @aws-cdk/aws-glue Related to AWS Glue label Nov 15, 2024
@khushail khushail added needs-reproduction This issue needs reproduction. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 15, 2024
@khushail khushail self-assigned this Nov 15, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-reproduction This issue needs reproduction. labels Nov 18, 2024
@khushail
Copy link
Contributor

Hi @urkle , thanks for reaching out. I see that in CDK documentation for Python shell jobs, it clearly mentions that Glue version is required.

Screenshot 2024-11-18 at 4 07 56 PM

Could you please share your insights on why this is not required and if this shared context of CDK Docs makes any sense.

Thanks

@khushail khushail added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Nov 19, 2024
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Nov 21, 2024
@urkle
Copy link
Author

urkle commented Nov 26, 2024

@khushail whenever I create pyhon shell jobs via CF I have to NOT set the glue_version to create the resource, otherwise it refuses to create saying that isn't supported.

And when I look at my jobs in the glue job list, the shell jobs have NO glue version specified at all.

image

The only value I was able to get to behave when using CDK was to set the glue version to 3.0 (some default somewhere I assume). But as you can see in the screenshot there is no glue version associated with my python shell job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-glue Related to AWS Glue bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants