feat(ec2): support throughput on LaunchTemplate EBS volumes

[isker]

Issue # (if applicable)

Fixes #24341.

Reason for this change

This support was simply not included in ec2 when it was added to autoscaling in #22441.

Description of changes

I have copied that PR's implementation implementation to ec2 and similarly adapted its tests.

Description of how you validated changes

Unit tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[isker]

Exemption Request

1. The EC2 README already has nothing to say about GP3 on LaunchTemplate BlockDevice volumes. It does talk about GP3 on ec2.Volumes already. I am not sure it's worth showing GP3 usage for LaunchTemplates as well.
2. The PR that added general throughput support to EC2 feat(autoscaling): support for throughput on GP3 volumes #22441 declined to add integration tests to EC2 and was still merged. I guess I'm similarly declining 🌞.

Perhaps this PR is better characterized as a fix? I'm not sure.

[isker]

Hi @pahud, since you have context on the linked issue, could you give me your thoughts on the above exemption request? Thanks!

[isker]

Hi @pahud sorry to ping you once again but I would appreciate your advice on how to proceed. Thanks.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[isker]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@pahud any help you can give me on this?

[GavinZZ]

Hi @isker, EC2 is also a stable module so I would highly recommend adding an simple integration test to use the throughput property to make sure it's deployable. It should be quite straightforward. For the linked similar PR you mentioned, it also added an integ test.

[isker]

@GavinZZ I see, I think I got confused because that PR added its test to packages/@aws-cdk/aws-autoscaling, and I saw no integration tests in packages/@aws-cdk/aws-ec2, but that's because everything got moved in a2c633f. I see where I can add integration test coverage for aws-ec2 now. I will do that.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 672fd0d
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[isker]

Alright, there's the integ coverage. I'm still not sure that this should be added to any README, for the reasons I already mentioned.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[isker]

@GavinZZ help 😢

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.