feat(core): configure SNS topics to receive stack events on the Stack construct #30551
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
comcalvi
added
the
pr-linter/exempt-integ-test
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
comcalvi
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
removed
the
pr/needs-maintainer-review
comcalvi
removed
pr/do-not-merge
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
comcalvi
added
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed stale reviews from themself
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
|
You guys, we cannot take changes to Cloud Assembly Schema in this repo any longer. Reverting this. |
Issue # (if applicable)
#8581.
Reason for this change
It is easier and clearer to specify the SNS Topic ARNs on the stack construct itself instead of passing it as a command line argument.
Description of changes
Added a new optional stack prop,
notificationArns, that is written to the CloudAssembly and concatenated with the CLI option--notification-arns.When I added CLI integ tests, I discovered that the existing framework is unable to use your local code. It always retrieves the latest release, which is not what you want when running it locally. This fixes that.
Don't forget to select stacks by hierarchical ID (currently display name, in our tests) when writing certain test code. Otherwise, the tests may not select the stack you expected.
Description of how you validated changes
Unit tests + CLI integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license