-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ssm): update simple name description and documentation #30653
Conversation
Ideally it would be nice to throw a warning at synthesize time, but that's not possible because this issue only happens with unresolved tokens in parameter name. We can't determine whether the unresolved token contains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor changes. Is there any validation present that checks if the simpleName
boolean value is appropriate for the given parameterName
? If not should we add some to enforce it or are there cases where we want to allow it?
There're codes to verify is |
Ohh gotcha, ok that should be fine then. |
@merigyfio update |
@mergify update |
✅ Branch has been successfully updated |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Issue # (if applicable)
Closes #28778.
Reason for this change
There are issues with SSM
StringParameter
where the parameter ARN would have missing/
or duplicate/
depending on the setup ofsimpleName
with unresolved tokens in the parameter name.Description of changes
Update README and docstring to explain to users when and how to correctly use
simpleName
parameter.Description of how you validated changes
No code changes made.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license