Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sagemaker): added support for ml.g6 instances #30948

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

prli
Copy link
Contributor

@prli prli commented Jul 25, 2024

Issue # (if applicable)

Closes #.

Reason for this change

G6 instances were announced for general availability in april 2024

Announcing general availability of Amazon EC2 G6 instances
G6 instances can be used for sagemaker notebooks and endpoints

image

I would like to add the instance type in cdk so that cdk app can spin up g6 instance as needed

Description of changes

defined new instanceTypes following the same convention as G5 instances

Description of how you validated changes

minor change and existing file does not have unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 25, 2024 04:43
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jul 25, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 25, 2024
@prli prli force-pushed the sm-g6-instance-support branch from 0a497ac to f56796e Compare July 26, 2024 23:48
@prli prli force-pushed the sm-g6-instance-support branch from f56796e to b970a1a Compare July 26, 2024 23:49
Copy link
Contributor

mergify bot commented Jul 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 29, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e99b020
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0e0cbfa into aws:main Jul 29, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Jul 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants