-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudfront): China regions do not support CachePolicy #31038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request This PR does not need to update the integ tests. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing ✅ A exemption request has been requested. Please wait for a maintainer's review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Comments on closed issues and PRs are hard for our team to see. |
Still clarifying some details internally on V1476577865.
AWS China regions do not have CachePolicy support yet the defaultBehavior would always render a behavior with
CachePolicyId
. This PR checks if the stack is deploying to a China region and optionally disable the CachePolicyId and add a dummyforwardedValues
prop, which is required ifCachePolicyId
undefined per CFN doc.As _renderBehavior() has to be executed in CDK synth time, the only way to check if we are deploying to an unsupported region is from the stack region env hence we note this requirement in the README.
Issue # (if applicable)
Closes #31033 and #13584
Reason for this change
Description of changes
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license