Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): add supportsSnapStart config to dotnet8 and python 3.12 #32112

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

Leo10Gama
Copy link
Member

Issue # (if applicable)

N/A

Description of changes

This change adds supportsSnapStart as true to dotnet8. This change is needed as Lambda Runtimes team is working on launching Snapstart support for dotnet8.

Original PR raised by @Beau-Gosse-dev

Description of how you validated changes

Verified the change is the same as Python and Java.

In addition, added new integ test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 13, 2024 17:21
@github-actions github-actions bot added the p2 label Nov 13, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (2f16415) to head (744b4fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32112   +/-   ##
=======================================
  Coverage   77.30%   77.30%           
=======================================
  Files         114      114           
  Lines        7627     7627           
  Branches     1360     1360           
=======================================
  Hits         5896     5896           
  Misses       1549     1549           
  Partials      182      182           
Flag Coverage Δ
suite.unit 77.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.30% <ø> (ø)

@Leo10Gama Leo10Gama marked this pull request as ready for review November 13, 2024 18:06
@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 13, 2024

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@paulhcsun
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Nov 13, 2024

update

✅ Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 744b4fc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 13, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 53f4713 into aws:main Nov 13, 2024
17 checks passed
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
@Leo10Gama Leo10Gama deleted the snapstart-py313-net8 branch November 13, 2024 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants