Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): cannot assume a doubly-chained role #32216

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(cli): cannot assume a doubly-chained role #32216

merged 1 commit into from
Nov 20, 2024

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Nov 20, 2024

Closes #32195

Reason for this change

Upgrading the version will pull in the required fix from the SDK: aws/aws-sdk-js-v3#6472

Description of changes

Only dependency upgrades

Description of how you validated changes

Manual test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 20, 2024 17:32
@github-actions github-actions bot added the p2 label Nov 20, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 20, 2024
@iliapolo iliapolo added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 20, 2024
@github-actions github-actions bot added bug This issue is a bug. p0 and removed p2 labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (1b7265b) to head (f5f7353).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32216   +/-   ##
=======================================
  Coverage   77.19%   77.19%           
=======================================
  Files         105      105           
  Lines        7166     7166           
  Branches     1314     1314           
=======================================
  Hits         5532     5532           
  Misses       1454     1454           
  Partials      180      180           
Flag Coverage Δ
suite.unit 77.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.19% <ø> (ø)
---- 🚨 Try these New Features:

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f5f7353
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 20, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8746e44 into main Nov 20, 2024
43 checks passed
@mergify mergify bot deleted the epolon/bump-sdk branch November 20, 2024 18:02
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p0 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK CLI: assuming a doubly-chained role fails since 2.167.0
4 participants