Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Optional flag to disable authorizer for "sam local start-api" #5285

Closed
mikepianka opened this issue Jun 7, 2023 · 4 comments
Labels
contributors/good-first-issue Good first issue for a contributor type/feature Feature request

Comments

@mikepianka
Copy link

Describe your idea/feature/enhancement

Being able to test API Gateway authorizers locally when running sam local start-api is a great new feature. However, I think it would be helpful to be able to pass an optional flag at the command line to disable the authorizer for local testing.

Proposal

Add an optional flag to disable API Gateway authorizers like sam local start-api --disable-authorizer

Things to consider:

  1. Will this require any updates to the SAM Spec

Additional Details

@mikepianka mikepianka added stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request labels Jun 7, 2023
@mildaniel
Copy link
Contributor

Thanks for the suggestion @mikepianka, I like the idea! We welcome contributions if you'd like tackle this yourself, if not, I'll take it back to the team for prioritization.

@mildaniel mildaniel added contributors/good-first-issue Good first issue for a contributor and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jun 7, 2023
@squizlee
Copy link
Contributor

Hi @mildaniel @mikepianka I've done an implementation. It's currently in a draft but it should satisfy this issue just fine :)

@hnnasit
Copy link
Contributor

hnnasit commented Jun 9, 2024

Closing as the PR has been merged and released.

@hnnasit hnnasit closed this as completed Jun 9, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributors/good-first-issue Good first issue for a contributor type/feature Feature request
Projects
None yet
Development

No branches or pull requests

4 participants