Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow User to Custom the Naming convention "{app_name}-{stage}-{func_name}" #1926

Open
MacHu-GWU opened this issue May 17, 2022 · 2 comments

Comments

@MacHu-GWU
Copy link

I found there are many "%s-%s-%s" % (app_name, stage, func_name) in the code base. In my organization they force to use {stage}-{app_name}-{func_name}. Is it possible to create a package level CONSTANT variable in chalice/app.py like NAMING_CONVENTION = "{app_name}-{stage}-{func_name}" that allow user to monkey patch this using their own naming convention?

I found five occurrence of this code snippet, I think the refact is as easy as adding at most five variable and fix the import. If the community believe it is a good idea to allow user to change the naming convention, I can issue an PR. Thank you.

@MacHu-GWU
Copy link
Author

PR issued #1927

@MacHu-GWU
Copy link
Author

Hi @jamesls, @stealthycoin any thoughts? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant