Fix proxy configuration for airgapped environments #7913
Conversation
eks-distro-bot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7913 +/- ##
=======================================
Coverage 73.46% 73.47%
=======================================
Files 577 577
Lines 35744 35745 +1
=======================================
+ Hits 26261 26262 +1
Misses 7826 7826
Partials 1657 1657 ☔ View full report in Codecov by Sentry. |
test/e2e/airgap.go
Outdated
| @@ -39,6 +39,21 @@ func runAirgapConfigFlow(test *framework.ClusterE2ETest, localCIDRs string) { | |||
| test.DeleteCluster() | |||
| } | |||
|
|
|||
| // runAirgapConfigProxyFlow run airgap deployment but allow bootstrap cluster to access local peers. | |||
There was a problem hiding this comment.
| // runAirgapConfigProxyFlow run airgap deployment but allow bootstrap cluster to access local peers. | |
| // runAirgapConfigProxyFlow runs air-gap deployment workflow with allowing bootstrap cluster to access local peers. |
There was a problem hiding this comment.
lets update the function comment for both runAirgapConfigProxyFlow and runAirgapConfigFlow, clarifying what the flow does in details for each case.
ahreehong
force-pushed
the
airgapped-proxy
branch
from
3605cde to
3f70625
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahreehong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.19 |
|
@ahreehong: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ahreehong: new pull request created: #7914 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
The CNI reconciler fails to generate cilium manifests in an airgapped environment because it tries to fetch the image from
public.ecr.awsinstead of through the proxy. This is due to the proxy configuration not being passed when constructing an instance of theHelmClientin the controller.This PR adds the proxyConfiguration as an option when building the
HelmClientTesting (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.