Misleading Error Message when extension name is > NAMEDATALEN

[JohnHVancouver]

postgres=# SELECT pgtle.install_extension
(
 'test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALEN',
 '0.1',
 'comment',
$_pg_tle_$                                                                         
    CREATE FUNCTION dist(x1 numeric, y1 numeric, x2 numeric, y2 numeric, l numeric)
    RETURNS numeric
    AS $$                                                                  
      SELECT ((x2 ^ l - x1 ^ l) ^ (1 / l)) + ((y2 ^ l - y1 ^ l) ^ (1 / l));
    $$ LANGUAGE SQL;
$_pg_tle_$
);
NOTICE:  identifier "test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALEN.control" will be truncated to "test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAM"
NOTICE:  identifier "test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALEN--0.1.sql" will be truncated to "test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAM"
ERROR:  Extension 'test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALEN' already installed.

It says the extension's already installed even though this is our first time installing it.

[jkatz]

I think #103 may address this. Going to try that out...

[jkatz]

I think there's a bug here, albeit at the edge.

NOTICE:  identifier "test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALEN.control" will be truncated to "test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAM"
NOTICE:  identifier "test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALEN--0.1.sql" will be truncated to "test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAM"
ERROR:  Extension 'test9greaterthanNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALENNAMEDATALEN' already installed.

What's happening is that the two functions we create (control function, version function) are truncated to have the same name. So it's coming across as the extension is already installed when really it's just the name is too long.

So yes, it's a misleading error message, but we're not capping the name of the extension to an appropriate length.

[jkatz]

Lowering the priority on this. I don't think this has v1.0.0 impact as it's an edge case. We should fix it in the fullness of time.

Leaving this in the milestone in case someone wants to pick it up, but deprioritizing it.