Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: triton v24.09 #4908

Merged
merged 8 commits into from
Oct 31, 2024
Merged

feat: triton v24.09 #4908

merged 8 commits into from
Oct 31, 2024

Conversation

maaquib
Copy link
Collaborator

@maaquib maaquib commented Oct 22, 2024

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@bhadrip bhadrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we keep repeating the aws accounts for each version ? are we expecting the versions to not be available in a given region ?

@maaquib
Copy link
Collaborator Author

maaquib commented Oct 22, 2024

Why do we keep repeating the aws accounts for each version ? are we expecting the versions to not be available in a given region ?

Not really sure. This is the convention that I see across all config files. If you guys have a better way, I'm happy to adopt it

@bhadrip
Copy link

bhadrip commented Oct 22, 2024

@nargokul do you have any insights in this image formats ?

@bhadrip
Copy link

bhadrip commented Oct 22, 2024

approving it for now, we should refactor the image discovery feature. @nargokul can add more context on the future direction.

@nileshvd nileshvd merged commit f82e154 into aws:master Oct 31, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants