Revert "change: add TGI 2.4.0 image uri (#4922)" #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ea5994.
Captainia
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
benieric
reviewed
Nov 13, 2024
| @@ -76,7 +76,7 @@ Before sending us a pull request, please ensure that: | |||
| 1. Install tox using `pip install tox` | |||
| 1. Install coverage using `pip install .[test]` | |||
| 1. cd into the sagemaker-python-sdk folder: `cd sagemaker-python-sdk` or `cd /environment/sagemaker-python-sdk` | |||
| 1. Run the following tox command and verify that all code checks and unit tests pass: `tox -- tests/unit` | |||
There was a problem hiding this comment.
Is this correct?
Locally I do tox -e py310 -- tests/unit
There was a problem hiding this comment.
This is a revert so we should reland this update later. I think the -e py310 is optional, just points which py version to use
benieric
approved these changes
Nov 13, 2024
gwang111
pushed a commit
to cj-zhang/sagemaker-python-sdk
that referenced
this pull request
Nov 14, 2024
gwang111
pushed a commit
to gwang111/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2024
mufaddal-rohawala
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Enable quantization and compilation in the same optimization job via ModelBuilder and add validations to block compilation jobs using TRTLLM an Llama-3.1. * Require EULA acceptance when using a gated 1p draft model via ModelBuilder. * add accept_draft_model_eula to JumpStartModel when deployment config with gated draft model is selected * add map of valid optimization combinations * Add ModelBuilder support for JumpStart-provided draft models. * Tweak draft model EULA validations and messaging. Remove redundant deployment_config flow validation in optimize_utils in favor of the one directly on jumpstart/factory/model. * Add "Auto" speculative decoding ModelProvider option; add validations to differentiate SageMaker/JumpStart draft models. * Fix JumpStartModel.AdditionalModelDataSource model access config assignment. * move the accept eula configurations into deploy flow * move the accept eula configurations into deploy flow * Use correct bucket for SM/JS draft models and minor formatting/validation updates. * Remove obsolete docstring. * remove references to accept_draft_model_eula * renaming of eula fn and error msg * fix: pin testing deps (#4925) Co-authored-by: nileshvd <113946607+nileshvd@users.noreply.github.com> * Revert "change: add TGI 2.4.0 image uri (#4922)" (#4926) * fix naming and messaging * ModelBuilder speculative decoding UTs and minor fixes. * Fix set union. * add UTs for JumpStart deployment * fix formatting issues * address validation comments * fix doc strings * Add TRTLLM compilation + speculative decoding validation. * address nits --------- Co-authored-by: Joseph Zhang <cjz@amazon.com> Co-authored-by: EC2 Default User <ec2-user@ip-172-16-2-151.us-west-2.compute.internal> Co-authored-by: Gary Wang 😤 <garywan@amazon.com> Co-authored-by: Gary Wang <38331932+gwang111@users.noreply.github.com> Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com> Co-authored-by: nileshvd <113946607+nileshvd@users.noreply.github.com> Co-authored-by: Haotian An <33510317+Captainia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0ea5994.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.