Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid image tag NPE in onboarding validation #538

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

brtrvn
Copy link
Contributor

@brtrvn brtrvn commented Dec 14, 2023

Compare the known not null image tag value from AppConfig for a service to the image tag value from a ECR listImages result to avoid a null pointer if the ECR list image result happens to not be tagged.

Resolves #533


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@brtrvn brtrvn merged commit 452d7ca into awslabs:main Dec 14, 2023
2 checks passed
@brtrvn brtrvn deleted the ecr-image-no-tag-npe branch December 19, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When there is a no tag docker image, can not create a new tanant in OnBoarding page
1 participant