Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use supported version of Node.js in development #1165

Closed
1 of 2 tasks
trivikr opened this issue Jul 31, 2024 · 4 comments
Closed
1 of 2 tasks

Use supported version of Node.js in development #1165

trivikr opened this issue Jul 31, 2024 · 4 comments
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged

Comments

@trivikr
Copy link
Member

trivikr commented Jul 31, 2024 •
edited
Loading

Use Case

I followed instructions in https://github.com/awslabs/aws-solutions-constructs/blob/main/CONTRIBUTING.md while attempting to contribute to the repo.

The following error was thrown by jsii on running npm run build+lint+test

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!                                                                            !!
!!  Node 16 has reached end-of-life on 2023-09-11 and is not supported.       !!
!!  Please upgrade to a supported node version as soon as possible.           !!
!!                                                                            !!
!!  This software is currently running on node v16.20.2.                      !!
!!  As of the current release of this software, supported node releases are:  !!
!!  - ^22.0.0 (Planned end-of-life: 2027-04-30)                               !!
!!  - ^20.0.0 (Planned end-of-life: 2026-04-30)                               !!
!!  - ^18.0.0 (Planned end-of-life: 2025-04-30)                               !!
!!                                                                            !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Proposed Solution

Use a supported version of Node.js for development.

Most projects use the latest LTS version.
At the time of writing in July 2024, it's Node.js 20.x

Other

N/A

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@trivikr trivikr added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Jul 31, 2024
@trivikr
Copy link
Member Author

trivikr commented Jul 31, 2024

This is likely a miss in CONTRIBUTING.md documentation

The DEVELOPER_GUIDE recommends jsii/superchain:1-bullseye-slim, a change made in #1141

@trivikr trivikr mentioned this issue Jul 31, 2024
Closed
@trivikr
Copy link
Member Author

trivikr commented Jul 31, 2024

Only doc update was needed.

Posted a PR at #1166

@biffgaut
Copy link
Contributor

biffgaut commented Aug 1, 2024

Thanks for pointing this out - the docker image had fallen behind in this file, the correct image to use is jsii/superchain:1-bullseye-slim. This is now updated in the doc.

@biffgaut biffgaut closed this as completed Aug 1, 2024
@trivikr
Copy link
Member Author

trivikr commented Aug 1, 2024 •
edited
Loading

Thanks! I'm glad that the fix made in commit be1c44e is the same as the one I'd posted in PR #1166

@trivikr trivikr mentioned this issue Aug 1, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: mention jsii/superchain:1-bullseye-slim in CONTRIBUTING trivikr/aws-solutions-constructs
2 participants
@trivikr @biffgaut