Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move crossplane addon v5 #146

Merged
merged 13 commits into from
Sep 12, 2023
Merged

Conversation

candonov
Copy link
Contributor

@candonov candonov commented Sep 11, 2023

What does this PR do?

Motivation

#109

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are installing ArgoCD and this repo is public. Do we want to install providers and their configuration through ArgoCD?

bootstrap/terraform/README.md Show resolved Hide resolved
bootstrap/terraform/main.tf Show resolved Hide resolved
examples/helm-provider/test-helm.yaml Outdated Show resolved Hide resolved
@candonov
Copy link
Contributor Author

For now, we are not planning to move the addons to ArgoCD.

Copy link
Contributor

@nabuskey nabuskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@candonov candonov merged commit 94398c8 into awslabs:main Sep 12, 2023
1 check passed
@candonov candonov deleted the move-crossplane-addon-v5 branch September 12, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants