Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Management Policies as Enabled for AWS-Upbound and AWS Providers #152

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Adding Management Policies as Enabled for AWS-Upbound and AWS Providers #152

merged 4 commits into from
Sep 26, 2023

Conversation

7navyasa
Copy link
Collaborator

@7navyasa 7navyasa commented Sep 25, 2023 •
edited by candonov
Loading

What does this PR do?

Adds enable management policies argument to aws-upbound and aws provider controller config.

Motivation

We need management policies enabled in order to import existing aws resources into crossplane. #142

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@7navyasa 7navyasa marked this pull request as ready for review September 26, 2023 02:57
candonov
candonov approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@candonov candonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@candonov candonov merged commit 10464a7 into awslabs:main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candonov candonov candonov approved these changes

@nabuskey nabuskey Awaiting requested review from nabuskey nabuskey is a code owner

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu vara-bonthu is a code owner

@nimakaviani nimakaviani Awaiting requested review from nimakaviani

@csantanapr csantanapr Awaiting requested review from csantanapr csantanapr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7navyasa @candonov