Use secret for storing connectioninfo (bucketname) in s3-irsa example #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update package version and args to match terraform bootstrap * Add deployment for crossplane helm provider and argocd to eksctl bootstrap * temporary change to region for testing with existing deployment in us-west-2 * Adjust permission boundary to allow CreateRole Quotes around ACCOUNT_ID in environmentconfig * Change region to us-east-1 to match default in terraform bootstrap Remove Deny for CreateRole Add missing ControllerConfig apply for Helm Provider
* Add annotations to for saving s3 bucket as secret for s3irsa example * Add writeConnectionSecretToRef to base.spec in Composition Change writeConnectionSecretToRef.name in claim in case of conflicts * Add annotations for ConnectionSecret to s3irsa composition * use secret for bucketname * corrected connectiondetails * change secret key to match configmap remove configmap
johnphilips3
requested review from
nabuskey,
vara-bonthu,
nimakaviani,
candonov and
csantanapr
as code owners
* fixing some warnings * matching service * reverting a test * feat(upgrade): upbound aws-provider to 1.2.1 and clearing warnings * upgrading eksclt as well * apigw warning cleanup
Adding Navya to Codeowners
Eksctl update (#2) * Update package version and args to match terraform bootstrap * Add deployment for crossplane helm provider and argocd to eksctl bootstrap * temporary change to region for testing with existing deployment in us-west-2 * Adjust permission boundary to allow CreateRole Quotes around ACCOUNT_ID in environmentconfig * Change region to us-east-1 to match default in terraform bootstrap Remove Deny for CreateRole Add missing ControllerConfig apply for Helm Provider
Request changes from PR Review
S3 secret fix (#4) * Add annotations to for saving s3 bucket as secret for s3irsa example * Add writeConnectionSecretToRef to base.spec in Composition Change writeConnectionSecretToRef.name in claim in case of conflicts * Add annotations for ConnectionSecret to s3irsa composition * use secret for bucketname * corrected connectiondetails * change secret key to match configmap remove configmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes s3-irsa examplea and related compositions to use a secret for the connectioninfo (bucketname) vs. configmap.
Associated version updates to crossplane and providers is also included for both terraform and eksctl bootstraps.
Motivation
Uses correct pattern now that provider bug has been fixed.
More
[ X] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ NA] Yes, I have added a new example under examples to support my PR
[NA ] Yes, I have updated the docs for this feature
[ NA] Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)
Note:
For Moderators
Additional Notes