Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 BucketPublicAccessBlock configuration under spec.forProvider #186

Merged
merged 1 commit into from
May 8, 2024

Conversation

vtumuluri
Copy link
Contributor

What does this PR do?

This PR fixes the BucketPublicAccessBlock resource by moving the access configuration from spec to spec.forProvider as is expected from the CRD.

Motivation

We use the S3 composition in our workflow and felt that it is beneficial to the community to contribute this fix rather than applying a local patch.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vtumuluri
Copy link
Contributor Author

@candonov @johnphilips3 Is there anything blocking the review? The existing example under /examples/upbound-aws-provider/composite-resources/s3.yaml already covers the use case which is the reason I haven't added another example. Also there are no additional elements introduced in this PR which is the reason I haven't modified any docs.

Copy link
Collaborator

@johnphilips3 johnphilips3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnphilips3 johnphilips3 merged commit 0b6957a into awslabs:main May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants