fix: adding more resources in the lua script #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarsilva948
requested review from
nabuskey,
vara-bonthu,
nimakaviani,
candonov,
csantanapr,
7navyasa and
johnphilips3
as code owners
candonov
reviewed
Jun 18, 2024
candonov
reviewed
Jun 19, 2024
Comment on lines
200
to
201
| "Composition", | ||
| "CompositionRevision", |
There was a problem hiding this comment.
are compositions and compositionrevisions *.apiextensions.crossplane.io, not *.aws.crossplane.io?
Comment on lines
202
to
203
| "DeploymentRuntimeConfig", | ||
| "ControllerConfig", |
There was a problem hiding this comment.
Same question deploymentruntimeconfigs.pkg.crossplane.io and controllerconfigs.pkg.crossplane.io not *.aws.crossplane.io?
Comment on lines
+273
to
+276
| "Composition", | ||
| "CompositionRevision", | ||
| "DeploymentRuntimeConfig", | ||
| "ControllerConfig", |
Comment on lines
344
to
347
| "Composition", | ||
| "CompositionRevision", | ||
| "DeploymentRuntimeConfig", | ||
| "ControllerConfig", |
|
Lua script adjusted to match the crossplane doc. |
candonov
reviewed
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adjusts the terraform bootstrap to have the new script added to the eksctl here: #198
Motivation
#198
More
Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
Yes, I have added a new example under examples to support my PR
Yes, I have updated the docs for this feature
Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)
Note:
For Moderators
Additional Notes