Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bedrock): bedrock.ChunkingStrategy.SEMANTIC is not implemented #587

Closed
1 of 2 tasks
grrapport opened this issue Jul 29, 2024 · 10 comments
Closed
1 of 2 tasks

(bedrock): bedrock.ChunkingStrategy.SEMANTIC is not implemented #587

grrapport opened this issue Jul 29, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@grrapport
Copy link

Describe the feature

Add support for ChunkingStrategy SEMANTIC as described here

Use Case

I want to use the SEMANTIC chunking strategy for a KnowledgeBase

Proposed Solution

Add value for SEMANTIC to relevant files.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@grrapport grrapport added the needs-triage This issue or PR still needs to be triaged. label Jul 29, 2024
@krokoko krokoko added enhancement New feature or request and removed needs-triage This issue or PR still needs to be triaged. labels Jul 29, 2024
@krokoko
Copy link
Collaborator

krokoko commented Jul 29, 2024

Hi @grrapport , thank you for this feature request ! I just started testing the 2 new chunking strategies, however when you try to deploy a template with either SEMANTIC or HIERARCHICAL you get an error like: 'HIERARCHICAL is not a valid enum value'. I will verify with the CloudFormation team if this is a bug and update this ticket accordingly.

@grrapport
Copy link
Author

Thank you, I was tinkering with it on my side too and having some problems with CFN as well.

@krokoko
Copy link
Collaborator

krokoko commented Aug 6, 2024

Hi @grrapport , I heard back from the team and this is an error in the documentation. Those new chunking strategies are not supported yet in CloudFormation. I will close this ticket and re-open it when the feature is available to link it to the PR.

@krokoko krokoko closed this as completed Aug 6, 2024
@krokoko
Copy link
Collaborator

krokoko commented Aug 20, 2024

Hi @grrapport , just FYI the support has been added and deployed in cfn (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-bedrock-datasource-chunkingconfiguration.html)
It should land in the cdk pretty soon, we'll implement it then. Thank you for your patience !

@aws-rafams
Copy link
Contributor

CDK support landed in 2.154.0: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_bedrock.CfnDataSource.html

@krokoko
Copy link
Collaborator

krokoko commented Aug 22, 2024

Great timing ! Reopening as available in the CDK now, will work on it

@krokoko krokoko reopened this Aug 22, 2024
@krokoko krokoko self-assigned this Aug 22, 2024
@krokoko
Copy link
Collaborator

krokoko commented Aug 22, 2024

This new feature requires the library to be updated to cdk v2.154.0, however I just found out that there is a bug in that version (see here: aws/aws-cdk#31183) which currently prevents the upgrade. The library won't build as a property was removed in cfnDataSource. Will need to wait for V2.154.X for the fix

@krokoko
Copy link
Collaborator

krokoko commented Aug 23, 2024

A new version with the bug fixed was released overnight, will resume work on this asap

@vaughngit
Copy link

Thank you for the updates!

@krokoko
Copy link
Collaborator

krokoko commented Sep 26, 2024

Closed with #668

@krokoko krokoko closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants