Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tough: clarify targets vs all_targets functions #423

Open
webern opened this issue Oct 19, 2021 · 0 comments
Open

tough: clarify targets vs all_targets functions #423

webern opened this issue Oct 19, 2021 · 0 comments

Comments

@webern
Copy link
Contributor

webern commented Oct 19, 2021

Repository::targets was created before we implemented delegated targets, then we added Repository::all_targets.

On pub fn targets in tough/src/lib.rs; it says Returns the list of targets present in the repository. which doesn't clarify about delegated targets, and 4 methods down is all_targets, which includes delegated, and says return a vec of all targets including all target files delegated by targets.

Maybe those two should be next to each other, with docstrings that make the difference clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant