Disabling secretsmanager via properties doesn't seem to work

[arunkpatra]

It appears that secretsmanager can't be disabled if one wishes to via properties. This behavior is seen in 2.3.x and 3.0.x branches. The below does not work, and causes app startup failure:

aws:
  secretsmanager:
    enabled: false

Application fails to start on above (I ensured that app failure is not due to want of unavailable properties):

09:19:35.684 [main] ERROR org.springframework.boot.SpringApplication - Application run failed
java.lang.IllegalStateException: Unable to load config data from 'aws-secretsmanager:/secrets/spring-cloud-aws-sample-app'
	at org.springframework.boot.context.config.StandardConfigDataLocationResolver.getReferences(StandardConfigDataLocationResolver.java:125)
	at org.springframework.boot.context.config.StandardConfigDataLocationResolver.resolve(StandardConfigDataLocationResolver.java:112)
	at org.springframework.boot.context.config.ConfigDataLocationResolvers.lambda$resolve$1(ConfigDataLocationResolvers.java:114)
	at org.springframework.boot.context.config.ConfigDataLocationResolvers.resolve(ConfigDataLocationResolvers.java:125)
	at org.springframework.boot.context.config.ConfigDataLocationResolvers.resolve(ConfigDataLocationResolvers.java:114)
	at org.springframework.boot.context.config.ConfigDataLocationResolvers.resolve(ConfigDataLocationResolvers.java:106)
	at org.springframework.boot.context.config.ConfigDataImporter.resolve(ConfigDataImporter.java:101)
	at org.springframework.boot.context.config.ConfigDataImporter.resolve(ConfigDataImporter.java:93)
	at org.springframework.boot.context.config.ConfigDataImporter.resolveAndLoad(ConfigDataImporter.java:81)
	at org.springframework.boot.context.config.ConfigDataEnvironmentContributors.withProcessedImports(ConfigDataEnvironmentContributors.java:119)
	at org.springframework.boot.context.config.ConfigDataEnvironment.processInitial(ConfigDataEnvironment.java:230)
	at org.springframework.boot.context.config.ConfigDataEnvironment.processAndApply(ConfigDataEnvironment.java:217)
	at org.springframework.boot.context.config.ConfigDataEnvironmentPostProcessor.postProcessEnvironment(ConfigDataEnvironmentPostProcessor.java:88)
	at org.springframework.boot.context.config.ConfigDataEnvironmentPostProcessor.postProcessEnvironment(ConfigDataEnvironmentPostProcessor.java:80)
	at org.springframework.boot.env.EnvironmentPostProcessorApplicationListener.onApplicationEnvironmentPreparedEvent(EnvironmentPostProcessorApplicationListener.java:100)
	at org.springframework.boot.env.EnvironmentPostProcessorApplicationListener.onApplicationEvent(EnvironmentPostProcessorApplicationListener.java:86)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:172)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:165)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:139)
	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:127)
	at org.springframework.boot.context.event.EventPublishingRunListener.environmentPrepared(EventPublishingRunListener.java:82)
	at org.springframework.boot.SpringApplicationRunListeners.lambda$environmentPrepared$2(SpringApplicationRunListeners.java:63)
	at java.util.ArrayList.forEach(ArrayList.java:1259)
	at org.springframework.boot.SpringApplicationRunListeners.doWithListeners(SpringApplicationRunListeners.java:117)
	at org.springframework.boot.SpringApplicationRunListeners.doWithListeners(SpringApplicationRunListeners.java:111)
	at org.springframework.boot.SpringApplicationRunListeners.environmentPrepared(SpringApplicationRunListeners.java:62)
	at org.springframework.boot.SpringApplication.prepareEnvironment(SpringApplication.java:362)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:320)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1309)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1298)
	at io.awspring.cloud.samples.secretsmanager.App.main(App.java:43)
Caused by: java.lang.IllegalStateException: File extension is not known to any PropertySourceLoader. If the location is meant to reference a directory, it must end in '/'
	at org.springframework.boot.context.config.StandardConfigDataLocationResolver.getReferencesForFile(StandardConfigDataLocationResolver.java:200)
	at org.springframework.boot.context.config.StandardConfigDataLocationResolver.getReferences(StandardConfigDataLocationResolver.java:122)
	... 30 common frames omitted

Of course one could just remove the dependency on secretsmanager-starter from their apps, but that probably defeats the purpose of the aws.secretsmanager.enabled switch in AwsSecretsManagerProperties.

What's the suggested behavior that we should implement in 3.0.x @maciejwalkowiak @MatejNedic @eddumelendez ? I could implement it via #79

[eddumelendez]

spring.config.import=optional:aws-secretsmanager:/secrets/spring-cloud-aws-sample-app/ can be used

[arunkpatra]

Yes, I get the same behavior too. But could you please try with enable:false also? But keep everything same in the setup you have mentioned above (except commenting out the @Value injection). WIth this setup, I am expecting your app to crash. Please let me know.

[arunkpatra]

I just did a quick sample, create /secret/message at Secrets Manager with value {"hello.secretmessage": "hi"} and use it in my project with spring.config.import=aws-secretsmanager:/secret/message and the following was resolved with value hi.

@Value("${hello.secretmessage}")
private String hello;

So, there is no need to / at the end.

Are you trying it out with 2.3?

[eddumelendez]

Yes, spring boot 2.4.0 and spring cloud aws 2.3.0-RC2

[arunkpatra]

Yes, spring boot 2.4.0 and spring cloud aws 2.3.0-RC2

Ok, please try once with enable:false.

[eddumelendez]

This is because spring-boot will evaluate any value on spring.config.import. See this and due to it is a property used for all ConfigDataResolvers then it produce that failure. I think this will be happening for all new configdataresolvers. I would recommend to declare what is being used, i.e, in this case remove that import and declare the property in the application.properties or the new method you are trying to use.