Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper_thread.h: fix missing header and types forward declaration #1602

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

dpronin
Copy link
Contributor

@dpronin dpronin commented Jul 27, 2023

  • missing headers should be included at the places where they are certainly used, so include <stdbool.h>
  • helper_thread_create() function requires two structures to be declared, so declare in advance struct fio_sem and struct sk_out

Signed-off-by: Denis Pronin dannftk@yandex.ru

missing headers should be included at the places where they are
certainly used

Signed-off-by: Denis Pronin <dannftk@yandex.ru>
helper_thread_create() function requires two structures to be declared

Signed-off-by: Denis Pronin <dannftk@yandex.ru>
@dpronin dpronin force-pushed the helper_thread-fix-missing-stdbool-header branch from 56644b0 to 5bf944a Compare July 27, 2023 19:23
@dpronin
Copy link
Contributor Author

dpronin commented Jul 27, 2023

@axboe again, changes do not seem to affect tests so they fail with iops ratio mismatch

@axboe axboe merged commit 45eb1cf into axboe:master Jul 27, 2023
9 of 10 checks passed
@dpronin dpronin deleted the helper_thread-fix-missing-stdbool-header branch July 27, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants