Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly free thread_data options at the topmost parent process #1603

Merged
merged 2 commits into from
Jul 28, 2023
Merged

correctly free thread_data options at the topmost parent process #1603

merged 2 commits into from
Jul 28, 2023

Commits on Jul 28, 2023

  1. fix missing headers in multiple files 

    some files require to have some missing headers included

Signed-off-by: Denis Pronin <dannftk@yandex.ru>
    @dpronin
    dpronin committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    1322921 View commit details
    Browse the repository at this point in the history

  2. correctly free thread_data options at the topmost parent process 

    for non-threaded mode: since thread_data::eo is a pointer within shared
memory between the topmost fio parent process and its children let the
fio parent process set the pointer to NULL as just it frees its copy of
'eo' as memory previously allocated by means of 'malloc' meaning that
each child and the parent process itself must free it

for threaded mode we leave it as it has always been

also we do not need to check td->io_ops for being able to free td->eo in
 fio_options_free()

Signed-off-by: Denis Pronin <dannftk@yandex.ru>
    @dpronin
    dpronin committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    913028e View commit details
    Browse the repository at this point in the history