Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv64: add system call definitions #1615

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

michalbiesek
Copy link
Contributor

No description provided.

@axboe
Copy link
Owner

axboe commented Oct 19, 2023

A commit message needs to explain WHY a change is being made. Your commit has a) basically no description, and b) what it does is just stating the obvious, I can see that from the patch.

In other words, please justify why this change is necessary in the commit message.

Use syscall helpers to optimized io_uring_enter(2) calls, eliminating
the need for libc functions. These wrappers are adapted from liburing.

Signed-off-by: michalbiesek <michalbiesek@gmail.com>
@michalbiesek
Copy link
Contributor Author

@axboe Thanks for the feedback. I have modified the commit message to be descriptive and explain the reason for the changes.

@axboe axboe merged commit f8735bf into axboe:master Oct 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants