Fix typo in helper_thread.c and run block_signals(void) function in linux only #1628
Conversation
The typo fix will now compile block_signals(void) correctly.
|
Please fix the Windows msys2 build error. It looks like pthread_sigmask may be defined to be a noop in msys2. Consider changing the test in the configure script to trigger the same warning that is in the build failure to fail to detect pthread_sigmask when it is defined to be a noop. |
|
@vincentkfu I think maybe we just delete the code? It's clearly been disabled forever and we haven't seen any signal related issues there. |
I haven't seen any signal related issues either although the commit message does mention some bugs resolved by this fix. Without any details of these bugs I don't have strong feelings either way. |
|
@axboe |
|
Ah, you did mention that in the initial part. Let's get a patch done first then that fixes the windows side, and then we can have the fix as the next patch. |
Compiling the code with the typo fix of "#ifdef CONFIG_PTHREAD_SIGMASK" will show that ret is unknown, hence, we are adding the line "int ret;". This fix of typo will fix some other bugs I've encountered. Also, sigmask works in linux environment, so we will if defined it to linux only. Signed-off-by: Shai Levy shailevy23@gmail.com
shailevi23
changed the title
The typo fix will now compile block_signals(void) correctly.
Please confirm that your commit message(s) follow these guidelines:
Compiling the code with the typo fix of "#ifdef CONFIG_PTHREAD_SIGMASK" will show that ret is unknown, hence, we are adding the line "int ret;".
This fix of typo will fix some other bugs I've encountered.
Signed-off-by: Shai Levy shailevy23@gmail.com