Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use "delete" term instead of "unlink", which is less common #1742

Merged
merged 1 commit into from
Mar 25, 2024
Merged

docs: use "delete" term instead of "unlink", which is less common #1742

merged 1 commit into from
Mar 25, 2024

Conversation

edigaryev
Copy link
Contributor

This way people would have an easier time discovering this command-line option, see #1739.

@axboe
Copy link
Owner

axboe commented Mar 25, 2024

I'm fine adding "delete" in there as well, but don't get rid of unlink. It may not mean anything to you, but it's a very commonly used word and in fact fully reflects what is being done here. As you may have noticed, it's what the option is called as well.

@edigaryev
Copy link
Contributor Author

I'm fine adding "delete" in there as well, but don't get rid of unlink.

See 4efb3c6.

@axboe
Copy link
Owner

axboe commented Mar 25, 2024

I think you missed some of your changes, and please squash them into one commit.

Signed-off-by: Nikolay Edigaryev <edigaryev@gmail.com>
@edigaryev
Copy link
Contributor Author

I think you missed some of your changes, and please squash them into one commit.

Good catch, see 3fe133a.

@axboe axboe merged commit b2403d4 into axboe:master Mar 25, 2024
@edigaryev edigaryev deleted the delete-instead-of-unlink branch March 25, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants