Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iolog, dataplacement: fix coverity scan defect #1767

Merged
merged 2 commits into from
May 31, 2024
Merged

iolog, dataplacement: fix coverity scan defect #1767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a70e681
iolog: fix Null pointer dereferences (FORWARD_NULL)
parkvibes May 30, 2024
4150d2e
iolog: fix Error handling issues (NEGATIVE_RETURNS)
parkvibes May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions iolog.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ static int ipo_special(struct thread_data *td, struct io_piece *ipo)
int dp_init_ret = dp_init(td);

if (dp_init_ret != 0) {
td_verror(td, dp_init_ret, "dp_init");
td_verror(td, abs(dp_init_ret), "dp_init");
return -1;
}
}
Expand Down Expand Up @@ -236,15 +236,15 @@ int read_iolog_get(struct thread_data *td, struct io_u *io_u)
io_u->buflen, io_u->file->file_name);
if (ipo->delay)
iolog_delay(td, ipo->delay);

if (td->o.dp_type != FIO_DP_NONE)
dp_fill_dspec_data(td, io_u);
} else {
elapsed = mtime_since_genesis();
if (ipo->delay > elapsed)
usec_sleep(td, (ipo->delay - elapsed) * 1000);
}

if (td->o.dp_type != FIO_DP_NONE)
dp_fill_dspec_data(td, io_u);

free(ipo);

if (io_u->ddir != DDIR_WAIT)
Expand Down
Loading