Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network requests failure rate is higher in yasio compared to java.net we use in cocos2dx #1931

Closed
battulasaivinesh opened this issue May 26, 2024 · 2 comments
Labels
help wanted Extra attention is needed wontfix This will not be worked on

Comments

@battulasaivinesh
Copy link

battulasaivinesh commented May 26, 2024

  • axmol version: axmol-2.1.2
  • devices test on: Produciton (Accross a vast set of devices)
  • developing environments
    • NDK version: r24c
    • Xcode version: 14.2+
    • cmake version: 3.28.1

After monitoring HTTP calls from our app, we observed that the failure rate of HTTP calls is double in axmol compared to cocos2dx 3.17. Here is the list of requests with different internal response codes -

Screenshot 2024-05-26 at 6 34 39 PM

Error rate added comes up to 6% of total requests, where as before in cocos 2dx 3.17 it used to be on 3% of total requests. The first one is considered as success.

Here is a sample code on how we are doing HTTP calls from our app -

network::HttpRequest* request = new network::HttpRequest();
request->setUrl(url);
request->setRequestType(network::HttpRequest::Type::POST);
request->setResponseCallback(
    [](network::HttpClient* client, network::HttpResponse* response) { callback() });
std::string userGetStr = JsonController::getJsonStringFromValueMap(payload);
request->setRequestData(userGetStr.c_str(), userGetStr.length());
network::HttpClient::getInstance()->send(request);
CC_SAFE_RELEASE(request);
@halx99 halx99 added the help wanted Extra attention is needed label Jun 6, 2024
Copy link

stale bot commented Aug 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 5, 2024
@smilediver
Copy link
Contributor

Maybe this is related to #2067. We had an issue where Axmol would flood the server with requests and it would start refusing connections.

@stale stale bot closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants