Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation #46

Open
getify opened this issue Aug 23, 2017 · 1 comment
Open

Translation #46

getify opened this issue Aug 23, 2017 · 1 comment

Comments

@getify
Copy link

getify commented Aug 23, 2017

I'm glad to see this effort to translate the book series into Russian. Since I don't speak the language, I'm not sure if the work is complete or not.

For more info about policies around translations of YDKJS, please check these issues: https://github.com/getify/You-Dont-Know-JS/issues?utf8=%E2%9C%93&q=is%3Aissue%20label%3A%22foreign%20language%20translations%22%20

In those threads you'll see described the preferred process for how foreign language translations should be handled. It's fine that the work is done on this separate repo, but once the translation is complete, the process then is:

  1. file an issue on the main repo to have a branch created for the translation
  2. send a PR to have the translation moved into that branch.
  3. At that point, the branch on the main repo becomes the "official" repo for the translation. I will add you as a collaborator so you can manage commits there.
@radislaw
Copy link

radislaw commented Nov 8, 2017

Я тоже предлагаю создать ветку с русским переводом на официальном репозитории книги и делать перевод уже в этой ветке

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants